business-settings: Policy settings#1996
Draft
pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Draft
business-settings: Policy settings#1996pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
pythcoiner wants to merge 2 commits intowizardsardine:masterfrom
Conversation
pythcoiner
force-pushed
the
policy_settings
branch
from
ed89c58 to
63fdb3c
Compare
pythcoiner
force-pushed
the
policy_settings
branch
from
63fdb3c to
84b1dc8
Compare
nondiremanuel
added
the
Nice to have
Collaborator
Author
|
I'll kept this in draft for now, it's not pressing and I'd like to not enable backup of encrypted descriptor before the BIP finalized |
Collaborator
|
I think that, even if not super urgent, having the possibility of reading the policy is still a good thing for users that want to be reassured about their setup after landing to the wallet. If it's not a lot of effort, I would personally consider splitting the PR and start merging that part (and possibly the plain text copy of the descriptor). Let's discuss this based on what's the effort required if needed. |
nondiremanuel
modified the milestones:
v14 Liana - Liana for Business,
v15 Liana - Liana Business improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a human readable policy section in Settings > Wallet & let user copy/backup the descriptor
closes #1992